Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_HAL_ChibiOS: add hwdef X-MAV-AP-H743v2 #28160

Merged
merged 2 commits into from
Sep 30, 2024
Merged

AP_HAL_ChibiOS: add hwdef X-MAV-AP-H743v2 #28160

merged 2 commits into from
Sep 30, 2024

Conversation

TompsonTan
Copy link
Contributor

Dear ArduPilot-Autopilot Developer, We are X-MAV, a new manufacturer of flight controllers. We have developed a flight controller AP-H743v2, We will keep developing it and want to add our flight controller to supported hardware.

Best regard!

AP-H743v2_3D_1

andyp1per
andyp1per previously requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@andyp1per andyp1per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor changes

@andyp1per
Copy link
Collaborator

The commits need to be split across subsystems

@TompsonTan
Copy link
Contributor Author

@andyp1per Hi, can these commits be merged now? Please feel free to let me know if there is any need to change it.

Hwurzburg
Hwurzburg requested changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs additional documentation....like this: https://github.com/ArduPilot/ardupilot/tree/master/libraries/AP_HAL_ChibiOS/hwdef/IFLIGHT_2RAW_H7

@TompsonTan
Copy link
Contributor Author

1.changed reserved id;
2.added document readme.md

Please review. Thanks again!

Hwurzburg
Hwurzburg requested changes Sep 26, 2024
View reviewed changes
libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/hwdef.dat Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/README.md Outdated Show resolved Hide resolved
libraries/AP_HAL_ChibiOS/hwdef/X-MAV-AP-H743v2/hwdef-bl.dat Show resolved Hide resolved
@Hwurzburg
Copy link
Collaborator

once final changes made, commits should be squashed and a library split made....you might want to break out the build_types.txt in a separate PR to reserve the bd id so someone else does not get it (first come/first served)...it gets merged almost immediately while this PR might take a review cycle or 2

@TompsonTan
Copy link
Contributor Author

Done:
1.added SD card interface in the bootloader to allow loading firmware from the SD card.
2.changed serial protocol default setting.
3.updated README.

@TompsonTan
Copy link
Contributor Author

board id reservation has been separate into another pr https://github.com/ArduPilot/ardupilot/pull/28253. Please merge it, thanks.

@TompsonTan @Hwurzburg
AP_HAL_ChibiOS: add board X-MAV-AP-H743v2
9287926 
Co-authored-by: Henry Wurzburg <hwurzburg@yahoo.com>
@Hwurzburg
Copy link
Collaborator

Since this looks close, I squashed and split for you...also removed the double define of OSD_TYPE in the hwdef.dat
did you update the bootloader bin with the new board id?

@TompsonTan
Copy link
Contributor Author

Since this looks close, I squashed and split for you...also removed the double define of OSD_TYPE in the hwdef.dat did you update the bootloader bin with the new board id?

bootloader of X-MAV-AP-H743v2 with the new board id 1174 updated now.

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Sep 28, 2024
@TompsonTan @Hwurzburg
Tools: add board X-MAV-AP-H743v2
44bbea5 
Co-authored-by: Henry Wurzburg <hwurzburg@yahoo.com>
Hwurzburg
Hwurzburg approved these changes Sep 29, 2024
View reviewed changes
Copy link
Collaborator

@Hwurzburg Hwurzburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Johnson, I squashed the new bootloader and marked for DEVCall
Would it be possible to get a couple of samples? I would like to update my DShot test fixture with an H7 board and this one looks ideal

@TompsonTan
Copy link
Contributor Author

Johnson, I squashed the new bootloader and marked for DEVCall Would it be possible to get a couple of samples? I would like to update my DShot test fixture with an H7 board and this one looks ideal

ok, i will send you some samples later.

@tridge tridge merged commit c5964ec into ArduPilot:master Sep 30, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker left review comments

@Hwurzburg Hwurzburg Hwurzburg approved these changes

@andyp1per andyp1per Awaiting requested review from andyp1per

Assignees
No one assigned
Labels
NewBoardSupport WikiNeeded needs wiki update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@TompsonTan @andyp1per @Hwurzburg @peterbarker @tridge @CraigElder